chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.h - Issue 2699213002: Adding MHTML support into Page Load Metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.h

Issue 2699213002: Adding MHTML support into Page Load Metrics (Closed)

Patch Set: bmcquade comment Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/browser_page_track_decider.cc ('k') | chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.h

index 17facaf8d63318eebc61174e831b240d169a0993..18063b665cec51395e6ee71b24bb27513efb6098 100644

--- a/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.h

@@ -5,6 +5,8 @@

#ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_PREVIEWS_PAGE_LOAD_METRICS_OBSERVER_H_

#define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_PREVIEWS_PAGE_LOAD_METRICS_OBSERVER_H_

+#include <string>

#include "base/macros.h"

#include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"

@@ -54,6 +56,8 @@ class PreviewsPageLoadMetricsObserver

const page_load_metrics::PageLoadExtraInfo& info) override;

void OnParseStart(const page_load_metrics::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& info) override;

+ ObservePolicy ShouldObserveMimeType(

+ const std::string& mime_type) const override;

private:

// Whether |web_contents| is showing an offline pages preview. Overridden in