Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8547)

Unified Diff: chrome/renderer/page_load_metrics/renderer_page_track_decider.cc

Issue 2699213002: Adding MHTML support into Page Load Metrics (Closed)
Patch Set: Only observe MHTML for previews observer Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/page_load_metrics/renderer_page_track_decider.cc
diff --git a/chrome/renderer/page_load_metrics/renderer_page_track_decider.cc b/chrome/renderer/page_load_metrics/renderer_page_track_decider.cc
index 861b13c351a121c6a60d991b23e97ff5e9e1a194..3340b792f14729cb531b129e66fc1220f7a1152a 100644
--- a/chrome/renderer/page_load_metrics/renderer_page_track_decider.cc
+++ b/chrome/renderer/page_load_metrics/renderer_page_track_decider.cc
@@ -45,13 +45,14 @@ int RendererPageTrackDecider::GetHttpStatusCode() {
bool RendererPageTrackDecider::IsHtmlOrXhtmlPage() {
// Ignore non-HTML documents (e.g. SVG). Note that images are treated by
// Blink as HTML documents, so to exclude images, we must perform
- // additional mime type checking below.
+ // additional mime type checking below. MHTML is tracked as HTML in blink.
if (!document_->isHTMLDocument() && !document_->isXHTMLDocument())
return false;
// Ignore non-HTML mime types (e.g. images).
blink::WebString mime_type = data_source_->response().mimeType();
- return mime_type == "text/html" || mime_type == "application/xhtml+xml";
+ return mime_type == "text/html" || mime_type == "application/xhtml+xml" ||
+ mime_type == "multipart/related";
}
} // namespace page_load_metrics

Powered by Google App Engine
This is Rietveld 408576698