content/browser/compositor/offscreen_browser_compositor_output_surface.cc - Issue 2699173002: cc: Make OutputSurfaceFrame::sub_buffer_rect optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/offscreen_browser_compositor_output_surface.cc

Issue 2699173002: cc: Make OutputSurfaceFrame::sub_buffer_rect optional (Closed)

Patch Set: Removed obsolete comment Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc ('k') | content/browser/renderer_host/compositor_impl_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/compositor/offscreen_browser_compositor_output_surface.cc

diff --git a/content/browser/compositor/offscreen_browser_compositor_output_surface.cc b/content/browser/compositor/offscreen_browser_compositor_output_surface.cc

index 8c7581c78d232b765dad08f9144b542e3cde64bd..bf2f87710f54171d0450e6b527ccfffbbeb99351 100644

--- a/content/browser/compositor/offscreen_browser_compositor_output_surface.cc

+++ b/content/browser/compositor/offscreen_browser_compositor_output_surface.cc

@@ -136,13 +136,12 @@ void OffscreenBrowserCompositorOutputSurface::SwapBuffers(

cc::OutputSurfaceFrame frame) {

gfx::Size surface_size = frame.size;

DCHECK(surface_size == reshape_size_);

- gfx::Rect swap_rect = frame.sub_buffer_rect;

if (reflector_) {

- if (swap_rect == gfx::Rect(surface_size))

- reflector_->OnSourceSwapBuffers(surface_size);

+ if (frame.sub_buffer_rect)

+ reflector_->OnSourcePostSubBuffer(*frame.sub_buffer_rect, surface_size);

else

- reflector_->OnSourcePostSubBuffer(swap_rect, surface_size);

+ reflector_->OnSourceSwapBuffers(surface_size);

}

// TODO(oshima): sync with the reflector's SwapBuffersComplete