content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc - Issue 2699173002: cc: Make OutputSurfaceFrame::sub_buffer_rect optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc

Issue 2699173002: cc: Make OutputSurfaceFrame::sub_buffer_rect optional (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/compositor/gpu_browser_compositor_output_surface.cc ('K') | « content/browser/compositor/gpu_browser_compositor_output_surface.cc ('k') | content/browser/compositor/offscreen_browser_compositor_output_surface.cc » ('j') | services/ui/surfaces/display_output_surface_ozone.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc

diff --git a/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc b/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc

index a6e74153846a66c1dc4af81bd75b42773287d2e1..ab748723e3416f0eb148ab723fb5ebf6c0761c89 100644

--- a/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc

+++ b/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc

@@ -73,7 +73,11 @@ void GpuSurfacelessBrowserCompositorOutputSurface::SwapBuffers(

// TODO(ccameron): What if a swap comes again before OnGpuSwapBuffersCompleted

// happens, we'd see the wrong swap size there?

swap_size_ = reshape_size_;

- buffer_queue_->SwapBuffers(frame.sub_buffer_rect);

+ gfx::Rect damage(swap_size_);

+ if (frame.sub_buffer_rect) {

danakj 2017/02/22 00:36:57 no {} :)

+ damage = *frame.sub_buffer_rect;

+ }

+ buffer_queue_->SwapBuffers(damage);

danakj 2017/02/22 00:36:57 it might be more readable with a ternary buffer

halliwell 2017/02/22 14:19:28 I prefer the ternary form, yes.

GpuBrowserCompositorOutputSurface::SwapBuffers(std::move(frame));

}