Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1315)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java

Issue 2699163003: Use VrCoreCompatibility check for whether to show an infobar instead of Android package manager. (Closed)
Patch Set: Check for OS support before vr core state Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java
index 2757b618f14ede02a6d795256d0f72d26b79e1c3..b72b9cab0d7aed173d6ae5deb443708934e1395e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java
@@ -4,13 +4,26 @@
package org.chromium.chrome.browser.vr_shell;
+import android.support.annotation.IntDef;
+
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+
/**
* Abstracts away the VrCoreVersionCheckerImpl class, which may or may not be present at runtime
* depending on compile flags.
*/
public interface VrCoreVersionChecker {
+ public static final int VR_NOT_AVAILABLE = 0;
+ public static final int VR_OUT_OF_DATE = 1;
+ public static final int VR_READY = 2;
+
+ @Retention(RetentionPolicy.SOURCE)
+ @IntDef({VR_NOT_AVAILABLE, VR_OUT_OF_DATE, VR_READY})
+ public @interface VrCoreCompatibility {}
+
/**
- * Test if VrCore version installed is compatible with Chromium.
+ * Check if VrCore is installed or if installed version is compatible with Chromium.
*/
- boolean isVrCoreCompatible();
+ int getVrCoreCompatibility();
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698