Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java

Issue 2699163003: Use VrCoreCompatibility check for whether to show an infobar instead of Android package manager. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java
index 2757b618f14ede02a6d795256d0f72d26b79e1c3..abe855e63f518b3e9f31b82ad6d31e2f0c066a58 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java
@@ -4,13 +4,26 @@
package org.chromium.chrome.browser.vr_shell;
+import android.support.annotation.IntDef;
+
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+
/**
* Abstracts away the VrCoreVersionCheckerImpl class, which may or may not be present at runtime
* depending on compile flags.
*/
public interface VrCoreVersionChecker {
+ public static final int VR_CORE_NOT_AVAILABLE = 0;
+ public static final int VR_CORE_OUT_OF_DATE = 1;
+ public static final int VR_CORE_READY = 2;
bshe 2017/02/21 15:53:08 optional nit: VR_CORE prefix is probably not neede
amp 2017/02/21 19:30:18 Done.
+
+ @Retention(RetentionPolicy.SOURCE)
+ @IntDef({VR_CORE_NOT_AVAILABLE, VR_CORE_OUT_OF_DATE, VR_CORE_READY})
+ public @interface VrCoreCompatibility {}
+
/**
* Test if VrCore version installed is compatible with Chromium.
bshe 2017/02/21 15:53:08 Update this comment
amp 2017/02/21 19:30:18 Done.
*/
- boolean isVrCoreCompatible();
+ int isVrCoreCompatible();
bshe 2017/02/21 15:53:08 It probably make sense to rename this function too
amp 2017/02/21 19:30:18 Done.
}

Powered by Google App Engine
This is Rietveld 408576698