Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: net/http/http_network_session.cc

Issue 2699163002: Whitelist net/ MemoryDumpProvider (Closed)
Patch Set: fix test on windows Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_cache_unittest.cc ('k') | net/spdy/spdy_session_pool_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_session.cc
diff --git a/net/http/http_network_session.cc b/net/http/http_network_session.cc
index fda084eab56900bcf246229fa108e0e9c72f91f0..b57653a3b77aea99af3d6904e8f0ee6f2e0a37fd 100644
--- a/net/http/http_network_session.cc
+++ b/net/http/http_network_session.cc
@@ -4,6 +4,8 @@
#include "net/http/http_network_session.h"
+#include <inttypes.h>
+
#include <utility>
#include "base/atomic_sequence_num.h"
@@ -423,7 +425,8 @@ void HttpNetworkSession::GetSSLConfig(const HttpRequestInfo& request,
void HttpNetworkSession::DumpMemoryStats(
base::trace_event::ProcessMemoryDump* pmd,
const std::string& parent_absolute_name) const {
- std::string name = base::StringPrintf("net/http_network_session_%p", this);
+ std::string name = base::StringPrintf("net/http_network_session_0x%" PRIxPTR,
+ reinterpret_cast<uintptr_t>(this));
base::trace_event::MemoryAllocatorDump* http_network_session_dump =
pmd->GetAllocatorDump(name);
if (http_network_session_dump == nullptr) {
@@ -439,6 +442,7 @@ void HttpNetworkSession::DumpMemoryStats(
quic_stream_factory_.DumpMemoryStats(
pmd, http_network_session_dump->absolute_name());
}
+
// Create an empty row under parent's dump so size can be attributed correctly
// if |this| is shared between URLRequestContexts.
base::trace_event::MemoryAllocatorDump* empty_row_dump =
« no previous file with comments | « net/http/http_cache_unittest.cc ('k') | net/spdy/spdy_session_pool_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698