Whitelist net/ MemoryDumpProvider

net/base/sdch_manager_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/sdch_manager.h"
 
 #include <limits.h>
 
 #include <memory>
 #include <string>
@@ skipping 622 matching lines @@
   EXPECT_EQ(target_gurl, observer.last_dictionary_url());
   EXPECT_EQ(server_hash, observer.last_server_hash());
 
   EXPECT_EQ(SDCH_OK, sdch_manager()->RemoveSdchDictionary(server_hash));
   EXPECT_EQ(1, observer.dictionary_removed_notifications());
   EXPECT_EQ(server_hash, observer.last_server_hash());
 
   sdch_manager()->RemoveObserver(&observer);
 }
 
-TEST_F(SdchManagerTest, DumpMemoryStats) {
+class SdchManagerMemoryDumpTest
+    : public SdchManagerTest,
+      public testing::WithParamInterface<
+          base::trace_event::MemoryDumpLevelOfDetail> {};
+
+INSTANTIATE_TEST_CASE_P(
+    /* no prefix */,
+    SdchManagerMemoryDumpTest,
+    ::testing::Values(base::trace_event::MemoryDumpLevelOfDetail::DETAILED,
+                      base::trace_event::MemoryDumpLevelOfDetail::BACKGROUND));
+
+TEST_P(SdchManagerMemoryDumpTest, DumpMemoryStats) {
   MockSdchObserver observer;
   sdch_manager()->AddObserver(&observer);
 
   std::string dictionary_domain("x.y.z.google.com");
   GURL target_gurl("http://" + dictionary_domain);
   std::string dictionary_text(NewSdchDictionary(dictionary_domain));
   std::string client_hash;
   std::string server_hash;
   SdchManager::GenerateHash(dictionary_text, &client_hash, &server_hash);
   EXPECT_TRUE(AddSdchDictionary(dictionary_text, target_gurl));
   EXPECT_EQ(1, observer.dictionary_added_notifications());
   EXPECT_EQ(target_gurl, observer.last_dictionary_url());
   EXPECT_EQ(server_hash, observer.last_server_hash());
 
-  base::trace_event::MemoryDumpArgs dump_args = {
-      base::trace_event::MemoryDumpLevelOfDetail::DETAILED};
+  base::trace_event::MemoryDumpArgs dump_args = {GetParam()};

[xunjieli, 2017/02/17 16:50:11]

sid: Do I need to set "ProcessMemoryDump::is_black_hole_non_fatal_for_testing_ =
true"
when in BACKGROUND mode?
Currently these tests will crash in BACKGROUND mode.

I guess I don't understand how this works.. How does it catch the case where
someone adds new dumps?

[ssid, 2017/02/21 18:07:43]

No. This shouldn't be set.
Sorry I forgot to mention. This has to be done along with this cl:
https://codereview.chromium.org/2667293003/ which adds the dump names to
whitelist.

Is it possible for you to take over that cl and merge it with this one?

[xunjieli, 2017/02/23 19:00:22]

Done.

   std::unique_ptr<base::trace_event::ProcessMemoryDump> pmd(
       new base::trace_event::ProcessMemoryDump(nullptr, dump_args));
 
   base::trace_event::MemoryAllocatorDump* parent =
       pmd->CreateAllocatorDump("parent");
   sdch_manager()->DumpMemoryStats(pmd.get(), parent->absolute_name());
 
   const base::trace_event::MemoryAllocatorDump* sub_dump =
       pmd->GetAllocatorDump("parent/sdch_manager");
   ASSERT_NE(nullptr, sub_dump);
@@ skipping 18 matching lines @@
       base::trace_event::MemoryAllocatorDump::kNameObjectCount, &count_attrs));
   std::string count;
   ASSERT_TRUE(count_attrs->GetString("value", &count));
   // One dictionary.
   EXPECT_EQ("1", count);
 
   sdch_manager()->RemoveObserver(&observer);
 }
 
 }  // namespace net