Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: pkg/compiler/lib/src/resolution/signatures.dart

Issue 2699073003: Support `void` as generic argument.
Patch Set: Add specialized messages for `void` for-ins. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/resolution/signatures.dart
diff --git a/pkg/compiler/lib/src/resolution/signatures.dart b/pkg/compiler/lib/src/resolution/signatures.dart
index 58e9177e091aa199f43d04501bd2fb865e2d9bf5..6d953ad6020c82e91ebb114cd7fb5c17b5e643f8 100644
--- a/pkg/compiler/lib/src/resolution/signatures.dart
+++ b/pkg/compiler/lib/src/resolution/signatures.dart
@@ -399,7 +399,7 @@ class SignatureResolver extends MappingVisitor<FormalElementX> {
}
switch (asyncMarker) {
case AsyncMarker.SYNC:
- returnType = visitor.resolveReturnType(returnNode);
+ returnType = visitor.resolveTypeAnnotation(returnNode);
break;
case AsyncMarker.SYNC_STAR:
ResolutionInterfaceType iterableType =
@@ -482,14 +482,6 @@ class SignatureResolver extends MappingVisitor<FormalElementX> {
}
ResolutionDartType resolveTypeAnnotation(TypeAnnotation annotation) {
- ResolutionDartType type = resolveReturnType(annotation);
- if (type.isVoid) {
- reporter.reportErrorMessage(annotation, MessageKind.VOID_NOT_ALLOWED);
- }
- return type;
- }
-
- ResolutionDartType resolveReturnType(TypeAnnotation annotation) {
if (annotation == null) return const ResolutionDynamicType();
ResolutionDartType result = resolver.resolveTypeAnnotation(annotation);
if (result == null) {

Powered by Google App Engine
This is Rietveld 408576698