Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 269903002: Revert of fix the error that path is inversed for stroke and strokeAndFill styles (Closed)

Created:
6 years, 7 months ago by reed2
Modified:
6 years, 7 months ago
Reviewers:
yunchao, bsalomon, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of fix the error that path is inversed for stroke and strokeAndFill styles (https://codereview.chromium.org/183683010/) TBR=reed@google.com NOTRY=True Reason for revert: broke unittests Original issue's description: > fix the error that path is inversed for stroke and strokeAndFill styles. > > However, because hairline stroke + fill = fill (see src/core/SkStrokeRec.cpp), strokeAndFill will be thought as fill style when paint.getStrokeWidth() <= 0, this edge case can be inverse-filled. > > BUG=skia:2222 > > Committed: http://code.google.com/p/skia/source/detail?r=14561 Committed: http://code.google.com/p/skia/source/detail?r=14562

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -28 lines) Patch
M expectations/gm/ignored-tests.txt View 1 chunk +0 lines, -13 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkDraw.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M src/core/SkStroke.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M src/gpu/GrStencilAndCoverPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
reed2
Created Revert of fix the error that path is inversed for stroke and strokeAndFill styles
6 years, 7 months ago (2014-05-04 18:05:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/269903002/1
6 years, 7 months ago (2014-05-04 18:05:37 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-04 18:05:38 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-04 18:05:38 UTC) #4
reed2
lgtm
6 years, 7 months ago (2014-05-04 18:05:56 UTC) #5
reed2
The CQ bit was checked by reed@chromium.org
6 years, 7 months ago (2014-05-04 18:06:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/269903002/1
6 years, 7 months ago (2014-05-04 18:06:37 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-04 18:06:38 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-04 18:06:38 UTC) #9
reed2
The CQ bit was checked by reed@chromium.org
6 years, 7 months ago (2014-05-04 18:08:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/269903002/1
6 years, 7 months ago (2014-05-04 18:08:17 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-04 18:08:29 UTC) #12
Message was sent while issue was closed.
Change committed as 14562

Powered by Google App Engine
This is Rietveld 408576698