chrome/browser/resources/settings/site_settings/edit_exception_dialog.html - Issue 2699013002: MD Settings: Allow editing a cookie site exception.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/site_settings/edit_exception_dialog.html

Issue 2699013002: MD Settings: Allow editing a cookie site exception. (Closed)

Patch Set: Localize string. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/app/settings_strings.grdp ('K') | « chrome/browser/resources/settings/site_settings/add_site_dialog.html ('k') | chrome/browser/resources/settings/site_settings/edit_exception_dialog.js » ('j') | chrome/browser/resources/settings/site_settings/edit_exception_dialog.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html ">

	2 <link rel="import" href="chrome://resources/html/polymer.html">
	dschuyler 2017/02/23 01:31:49 Let's import polymer.html first; I hear it's the r Let's import polymer.html first; I hear it's the right thing to do. dpapad 2017/02/23 19:39:47 Correct. Done. Show quoted text On 2017/02/23 at 01:31:49, dschuyler wrote: > Let's import polymer.html first; I hear it's the right thing to do. Correct. Done.
	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">

	4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html">

	5 <link rel="import" href="../i18n_setup.html">

	6 <link rel="import" href="site_settings_prefs_browser_proxy.html">

	7

	8 <dom-module id="settings-edit-exception-dialog">

	9 <template>

	10 <style include="settings-shared"></style>

	11 <dialog is="cr-dialog" id="dialog">

	12 <div class="title">$i18n{editSiteDialogTitle}</div>

	13 <div class="body">

	14 <paper-input always-float-label id="url" label="$i18n{onStartupSiteUrl}"

	15 value="{{origin_}}" on-keypress="onKeypress_">

	16 </paper-input>

	17 </div>

	18 <div class="button-container">

	19 <div class="action-buttons">

	20 <paper-button class="cancel-button" on-tap="onCancelTap_"

	21 id="cancel">$i18n{cancel}</paper-button>

	22 <paper-button id="actionButton" class="action-button"

	23 disabled="[[!origin_.length]]"
	dschuyler 2017/02/23 01:31:49 Please validate the url with something like this.b Please validate the url with something like this.browserProxy.isPatternValid to control whether the action button is disabled. dpapad 2017/02/23 19:39:47 Thanks. Done (and updated tests). Show quoted text On 2017/02/23 at 01:31:49, dschuyler wrote: > Please validate the url with something like this.browserProxy.isPatternValid to control whether the action button is disabled. Thanks. Done (and updated tests).
	24 on-tap="onActionButtonTap_">$i18n{edit}</paper-button>

	25 </div>

	26 </div>

	27 </dialog>

	28 </template>

	29 <script src="edit_exception_dialog.js"></script>

	30 </dom-module>

OLD	NEW