Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2698993002: Use only MemoryByteStore in analyzer_cli. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use only MemoryByteStore in analyzer_cli. Unfortunately evicting from cache makes it slow to use in potentially short running cli tool. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e8c29784374b32b5d883fb45f51a8fe5bc5223fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -21 lines) Patch
M pkg/analyzer_cli/lib/src/driver.dart View 4 chunks +1 line, -21 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
3 years, 10 months ago (2017-02-16 20:14:16 UTC) #1
Brian Wilkerson
Could we use MemoryByteStore only when running in batch mode? Would that be safe? (It ...
3 years, 10 months ago (2017-02-16 20:41:13 UTC) #2
scheglov
On 2017/02/16 20:41:13, Brian Wilkerson wrote: > Could we use MemoryByteStore only when running in ...
3 years, 10 months ago (2017-02-16 21:53:29 UTC) #3
Brian Wilkerson
Sounds reasonable. lgtm
3 years, 10 months ago (2017-02-16 21:54:45 UTC) #4
scheglov
3 years, 10 months ago (2017-02-16 22:07:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e8c29784374b32b5d883fb45f51a8fe5bc5223fe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698