Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2698943002: Add dart_bootstrap/gen_snapshot/dart_precompiled_runtime to task_kill.py (by default) (Closed)

Created:
3 years, 10 months ago by kustermann
Modified:
3 years, 10 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add dart_bootstrap/gen_snapshot/dart_precompiled_runtime to task_kill.py (by default) On Windows we had hanging dart_bootstrap.exe which prevented builds. So with this change will we ensure to kill these leaked processes if they occur. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/fa36b348877349774139b2c650b427d7a193d9fd

Patch Set 1 #

Total comments: 6

Patch Set 2 : remove fletch in task_kill.py #

Patch Set 3 : add status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -18 lines) Patch
M tools/task_kill.py View 1 2 4 chunks +15 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
kustermann
3 years, 10 months ago (2017-02-16 11:25:38 UTC) #2
Florian Schneider
Lgtm https://codereview.chromium.org/2698943002/diff/1/tools/task_kill.py File tools/task_kill.py (right): https://codereview.chromium.org/2698943002/diff/1/tools/task_kill.py#newcode33 tools/task_kill.py:33: 'fletch': 'fletch.exe', Can be removed? https://codereview.chromium.org/2698943002/diff/1/tools/task_kill.py#newcode34 tools/task_kill.py:34: 'fletch-vm': ...
3 years, 10 months ago (2017-02-16 11:45:10 UTC) #3
kustermann
3 years, 10 months ago (2017-02-16 11:49:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
fa36b348877349774139b2c650b427d7a193d9fd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698