Issue 269893002: aw: Avoid using std::max for compile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 269893002: aw: Avoid using std::max for compile (Closed)

Created:
6 years, 7 months ago by boliu

Modified:
6 years, 7 months ago

Reviewers:
hush (inactive)

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

aw: Avoid using std::max for compile On x64, the call is confusing the compiler about deducing the template type. Off-by-one is not a big deal here, so using same calculation as bytes. BUG= TBR=hush Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268114

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	android_webview/browser/browser_view_renderer.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/269893002/1

6 years, 7 months ago (2014-05-04 15:40:46 UTC) #3

Message was sent while issue was closed.

Change committed as 268114

Expand Messages | Collapse Messages