Chromium Code Reviews Chromium Code Reviews
Issue 2698843003:
Convert more miscellaneous tests to testharness (Closed)
| Index: third_party/WebKit/LayoutTests/webaudio/audiosummingjunction-crash.html |
| diff --git a/third_party/WebKit/LayoutTests/webaudio/audiosummingjunction-crash.html b/third_party/WebKit/LayoutTests/webaudio/audiosummingjunction-crash.html |
| index d00cdde00e60684df0a5ec68b44a79caa86091ba..0684ec71b9ace318fa00a15c0d485d5e5fc64468 100644 |
| --- a/third_party/WebKit/LayoutTests/webaudio/audiosummingjunction-crash.html |
| +++ b/third_party/WebKit/LayoutTests/webaudio/audiosummingjunction-crash.html |
| @@ -1,10 +1,26 @@ |
| <body> |
| -<script src="../resources/js-test.js"> |
| +<script src="../resources/testharness.js"></script> |
| +<script src="../resources/testharnessreport.js"></script> |
| +<script src="resources/audit.js"></script> |
| <script> |
| -description("This test passes if it doesn't crash."); |
| -var ac = new AudioContext(); |
| -var node = ac.createChannelMerger(4); |
| -node.connect(ac.createMediaStreamDestination(), 0); |
| -gc(); |
| +let audit = Audit.createTaskRunner(); |
| + |
| +audit.define( |
| + { |
| + label: 'test', |
| + description: |
| + 'Test connection from ChannelMerger to MediaStreamAudioDestination' |
| + }, |
| + (task, should) => { |
| + let ac = new AudioContext(); |
|
hongchan
2017/02/27 18:21:52
ac => audioContext or context
Raymond Toy
2017/02/27 18:51:49
Done.
|
| + let node = ac.createChannelMerger(4); |
| + node.connect(ac.createMediaStreamDestination(), 0); |
| + gc(); |
| + // Test passes if we get here because we didn't crash |
| + should(true, 'Test survived GC').message('correctly', 'incorrectly'); |
| + task.done(); |
| + }); |
| + |
| +audit.run(); |
| </script> |
| </body> |
