Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Side by Side Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2698813007: Fix teardown of stale AudioStreamMonitor poll callbacks. (Closed)
Patch Set: Always store callbacks, fix tests. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/media/audio_stream_monitor_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_impl.h" 5 #include "content/browser/web_contents/web_contents_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <cmath> 9 #include <cmath>
10 #include <utility> 10 #include <utility>
(...skipping 4376 matching lines...) Expand 10 before | Expand all | Expand 10 after
4387 // renderer may not have made a clean exit. 4387 // renderer may not have made a clean exit.
4388 if (IsFullscreenForCurrentTab()) 4388 if (IsFullscreenForCurrentTab())
4389 ExitFullscreenMode(false); 4389 ExitFullscreenMode(false);
4390 4390
4391 // Cancel any visible dialogs so they are not left dangling over the sad tab. 4391 // Cancel any visible dialogs so they are not left dangling over the sad tab.
4392 CancelActiveAndPendingDialogs(); 4392 CancelActiveAndPendingDialogs();
4393 4393
4394 if (delegate_) 4394 if (delegate_)
4395 delegate_->HideValidationMessage(this); 4395 delegate_->HideValidationMessage(this);
4396 4396
4397 audio_stream_monitor_.RenderProcessGone(rvh->GetProcess()->GetID());
4398
4397 // Reset the loading progress. TODO(avi): What does it mean to have a 4399 // Reset the loading progress. TODO(avi): What does it mean to have a
4398 // "renderer crash" when there is more than one renderer process serving a 4400 // "renderer crash" when there is more than one renderer process serving a
4399 // webpage? Once this function is called at a more granular frame level, we 4401 // webpage? Once this function is called at a more granular frame level, we
4400 // probably will need to more granularly reset the state here. 4402 // probably will need to more granularly reset the state here.
4401 ResetLoadProgressState(); 4403 ResetLoadProgressState();
4402 NotifyDisconnected(); 4404 NotifyDisconnected();
4403 SetIsCrashed(status, error_code); 4405 SetIsCrashed(status, error_code);
4404 4406
4405 for (auto& observer : observers_) 4407 for (auto& observer : observers_)
4406 observer.RenderProcessGone(GetCrashedStatus()); 4408 observer.RenderProcessGone(GetCrashedStatus());
(...skipping 1004 matching lines...) Expand 10 before | Expand all | Expand 10 after
5411 GetMainFrame()->AddMessageToConsole( 5413 GetMainFrame()->AddMessageToConsole(
5412 content::CONSOLE_MESSAGE_LEVEL_WARNING, 5414 content::CONSOLE_MESSAGE_LEVEL_WARNING,
5413 base::StringPrintf("This site does not have a valid SSL " 5415 base::StringPrintf("This site does not have a valid SSL "
5414 "certificate! Without SSL, your site's and " 5416 "certificate! Without SSL, your site's and "
5415 "visitors' data is vulnerable to theft and " 5417 "visitors' data is vulnerable to theft and "
5416 "tampering. Get a valid SSL certificate before" 5418 "tampering. Get a valid SSL certificate before"
5417 " releasing your website to the public.")); 5419 " releasing your website to the public."));
5418 } 5420 }
5419 5421
5420 } // namespace content 5422 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/media/audio_stream_monitor_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698