Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/bin/file_android.cc

Issue 2698813002: [dart:io][windows] Make unicode characters display correctly. (Closed)
Patch Set: Make tests pass Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/bin/file.cc ('K') | « runtime/bin/file.cc ('k') | runtime/bin/file_fuchsia.cc » ('j') | runtime/bin/file_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/file_android.cc
diff --git a/runtime/bin/file_android.cc b/runtime/bin/file_android.cc
index 3eb50958cd11bab8af787e436cdec1fc3f1f971b..68afdb9772faa34ad5df3e2d9bb2271229acce50 100644
--- a/runtime/bin/file_android.cc
+++ b/runtime/bin/file_android.cc
@@ -132,6 +132,9 @@ bool File::SetPosition(int64_t position) {
}
+void File::SetTranslation(DartFileTranslation translation) {}
siva 2017/02/22 00:58:45 Maybe add a comment here stating there is nothing
zra 2017/02/22 05:07:15 Done.
+
+
bool File::Truncate(int64_t length) {
ASSERT(handle_->fd() >= 0);
return TEMP_FAILURE_RETRY(ftruncate(handle_->fd(), length) != -1);
« runtime/bin/file.cc ('K') | « runtime/bin/file.cc ('k') | runtime/bin/file_fuchsia.cc » ('j') | runtime/bin/file_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698