Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1185)

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 2698793003: Get rid of redundant layout tree update related to selection (Closed)
Patch Set: 2017-02-16T17:15:58 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/FrameSelection.h
diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.h b/third_party/WebKit/Source/core/editing/FrameSelection.h
index 6e26920c8dc7496ad381932915196860df7c2451..59b3e09441b910864ec8d56192498017293725a7 100644
--- a/third_party/WebKit/Source/core/editing/FrameSelection.h
+++ b/third_party/WebKit/Source/core/editing/FrameSelection.h
@@ -169,7 +169,7 @@ class CORE_EXPORT FrameSelection final
return selection().getSelectionType();
}
- TextAffinity affinity() const { return selection().affinity(); }
+ TextAffinity affinity() const { return selectionInDOMTree().affinity(); }
bool modify(EAlteration,
SelectionDirection,
@@ -204,7 +204,6 @@ class CORE_EXPORT FrameSelection final
void didChangeFocus();
const SelectionInDOMTree& selectionInDOMTree() const;
- // TODO(yosin): We should rename |isNone()| to |isVisibleNone()|.
bool isNone() const { return selection().isNone(); }
bool isCaret() const { return selection().isCaret(); }
bool isRange() const { return selection().isRange(); }

Powered by Google App Engine
This is Rietveld 408576698