third_party/WebKit/Source/core/editing/Editor.cpp - Issue 2698793003: Get rid of redundant layout tree update related to selection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/Editor.cpp

Issue 2698793003: Get rid of redundant layout tree update related to selection (Closed)

Patch Set: 2017-02-17T14:18:09 DisallowTransition Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/Editor.cpp

diff --git a/third_party/WebKit/Source/core/editing/Editor.cpp b/third_party/WebKit/Source/core/editing/Editor.cpp

index 4bf340fd5f88a108d11159655cef891e15700d7c..e76013abf83f3a8f1f2d7d4fee620ed130d439a1 100644

--- a/third_party/WebKit/Source/core/editing/Editor.cpp

+++ b/third_party/WebKit/Source/core/editing/Editor.cpp

@@ -1627,8 +1627,11 @@ void Editor::respondToChangedSelection(

const Position& oldSelectionStart,

FrameSelection::SetSelectionOptions options) {

spellChecker().respondToChangedSelection(oldSelectionStart, options);

- client().respondToChangedSelection(&frame(),

- frame().selection().getSelectionType());

+ client().respondToChangedSelection(

+ &frame(), frame()

+ .selection()

+ .selectionInDOMTree()

+ .computeSelectionTypeConsideringGranularity());

setStartNewKillRingSequence(true);

}