third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp - Issue 2698793003: Get rid of redundant layout tree update related to selection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

Issue 2698793003: Get rid of redundant layout tree update related to selection (Closed)

Patch Set: 2017-02-17T00:37:54 FrameSelection::selectFrameElementInParentIfFullySelected() to use FS::isRange() Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

index 5532d32b845d6a5547bde358e1e205171f647aaa..3b3dddb1c63a520c5e354cdb6888fe2be1ee0087 100644

--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

@@ -494,7 +494,11 @@ void SpellChecker::markMisspellingsAfterTypingToWord(

}

bool SpellChecker::isSpellCheckingEnabledInFocusedNode() const {

- Node* focusedNode = frame().selection().start().anchorNode();

+ Node* focusedNode = frame()

+ .selection()

+ .selectionInDOMTree()

+ .computeStartPosition()

+ .anchorNode();

if (!focusedNode)

return false;

const Element* focusedElement = focusedNode->isElementNode()