third_party/WebKit/LayoutTests/http/tests/resources/last-modified.php - Issue 2698773005: document.lastModified: treat invalid dates like unknown ones.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/resources/last-modified.php

Issue 2698773005: document.lastModified: treat invalid dates like unknown ones. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/misc/last-modified-parsing-expected.txt ('k') | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/resources/last-modified.php

diff --git a/third_party/WebKit/LayoutTests/http/tests/resources/last-modified.php b/third_party/WebKit/LayoutTests/http/tests/resources/last-modified.php

index 6465f77cd6133177b723e53ed6f3aa057d343161..8dded1c4e755e2163212b120076bcadb4957387a 100644

--- a/third_party/WebKit/LayoutTests/http/tests/resources/last-modified.php

+++ b/third_party/WebKit/LayoutTests/http/tests/resources/last-modified.php

@@ -6,7 +6,13 @@

var expected = '<?=$expected?>';

var lastModified = document.lastModified;

-if (expected == lastModified) {

+// If expected is 'illformed-date', then the Last-Modified: header

+// is assumed to contain an unparseable date. For which we're supposed

+// to return the current time per spec. Simply verify that by checking

+// that the |lastModified| parses.

+if (expected === lastModified ||

+ (expected === "illformed-date" && !isNaN(Date.parse(lastModified)))) {

document.write('PASS');

} else {

document.write('FAIL: expect ' + expected + ', but got ' + lastModified);