Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1667)

Unified Diff: chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.js

Issue 2698773004: Settings: Hide fingerprint setup from options. (Closed)
Patch Set: Fixed patch set 2 errors. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/people_page/lock_screen.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.js
diff --git a/chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.js b/chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.js
index b6d067801353192aad15c98251587b1b25b5594b..9204da0af5194f15bcda29afc75d122bffa63ae6 100644
--- a/chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.js
+++ b/chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.js
@@ -65,11 +65,13 @@ cr.define('options', function() {
settings.navigateTo(settings.Route.LOCK_SCREEN);
var lockScreen = document.querySelector('settings-lock-screen');
- var checkbox =
- lockScreen.root.querySelector(
- 'div.settings-box.single-column.screen-lock');
+ var checkbox = lockScreen.root.querySelector('div.settings-box');
stevenjb (google-dont-use) 2017/02/23 17:10:57 Why this selector change? It seems fragile. It was
sammiequon 2017/02/23 22:31:04 Yeah, I noticed it was not working while working o
checkbox.hidden = true;
+ // The fingerprint settings on options is always hidden.
+ var fingerprintDiv = lockScreen.root.querySelector('#fingerprintDiv');
+ fingerprintDiv.hidden = true;
+
var passwordPrompt = lockScreen.root.
querySelector('settings-password-prompt-dialog');
passwordPrompt.addEventListener('close', function() {
« no previous file with comments | « no previous file | chrome/browser/resources/settings/people_page/lock_screen.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698