Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Unified Diff: ios/web/web_state/ui/crw_web_controller_unittest.mm

Issue 2698773002: [iOS] Refactoring web CRWSessionController user agent code. (Closed)
Patch Set: Fix unit tests and rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/web_state/ui/crw_web_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/ui/crw_web_controller_unittest.mm
diff --git a/ios/web/web_state/ui/crw_web_controller_unittest.mm b/ios/web/web_state/ui/crw_web_controller_unittest.mm
index 749b5b6ca2661fa91d0d003268f0381550f2f8f1..16fad14247690940d8d34003da74cccaa566212b 100644
--- a/ios/web/web_state/ui/crw_web_controller_unittest.mm
+++ b/ios/web/web_state/ui/crw_web_controller_unittest.mm
@@ -218,11 +218,10 @@ void SetUp() override {
NavigationManagerImpl& navigationManager =
[web_controller() webStateImpl]->GetNavigationManagerImpl();
navigationManager.InitializeSession(@"name", nil, NO, 0);
- [navigationManager.GetSessionController()
- addPendingItem:GURL("http://www.google.com/?q=foo#bar")
- referrer:web::Referrer()
- transition:ui::PAGE_TRANSITION_TYPED
- rendererInitiated:NO];
+ navigationManager.AddPendingItem(
+ GURL("http://www.google.com/?q=foo#bar"), web::Referrer(),
+ ui::PAGE_TRANSITION_TYPED,
+ web::NavigationInitiationType::USER_INITIATED);
}
void TearDown() override {
@@ -810,11 +809,9 @@ void Load(const GURL& URL) {
NavigationManagerImpl& navigation_manager =
[web_controller() webStateImpl]->GetNavigationManagerImpl();
navigation_manager.InitializeSession(@"name", nil, NO, 0);
- [navigation_manager.GetSessionController()
- addPendingItem:URL
- referrer:web::Referrer()
- transition:ui::PAGE_TRANSITION_TYPED
- rendererInitiated:NO];
+ navigation_manager.AddPendingItem(
+ URL, web::Referrer(), ui::PAGE_TRANSITION_TYPED,
+ web::NavigationInitiationType::USER_INITIATED);
[web_controller() loadCurrentURL];
}
« no previous file with comments | « ios/web/web_state/ui/crw_web_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698