Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: ios/web/navigation/crw_session_controller.h

Issue 2698773002: [iOS] Refactoring web CRWSessionController user agent code. (Closed)
Patch Set: Fix unit tests and rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab_unittest.mm ('k') | ios/web/navigation/crw_session_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/navigation/crw_session_controller.h
diff --git a/ios/web/navigation/crw_session_controller.h b/ios/web/navigation/crw_session_controller.h
index d2ef34228f308c5c24ad20c3ef7be774de9bb962..d5cfeb58adfa0be3cb82b6f10eff80f96f970251 100644
--- a/ios/web/navigation/crw_session_controller.h
+++ b/ios/web/navigation/crw_session_controller.h
@@ -19,6 +19,7 @@ namespace web {
class BrowserState;
class NavigationItemImpl;
class NavigationManagerImpl;
+enum class NavigationInitiationType;
struct Referrer;
}
@@ -96,13 +97,13 @@ struct Referrer;
- (void)setBrowserState:(web::BrowserState*)browserState;
// Add a new item with the given url, referrer, and navigation type, making it
-// the current item. If |url| is the same as the current item's url, this
-// does nothing. |referrer| may be nil if there isn't one. The item starts
-// out as pending, and will be lost unless |-commitPendingItem| is called.
+// the current item. If pending item is the same as current item, this does
+// nothing. |referrer| may be nil if there isn't one. The item starts out as
+// pending, and will be lost unless |-commitPendingItem| is called.
- (void)addPendingItem:(const GURL&)url
referrer:(const web::Referrer&)referrer
transition:(ui::PageTransition)type
- rendererInitiated:(BOOL)rendererInitiated;
+ initiationType:(web::NavigationInitiationType)initiationType;
// Updates the URL of the yet to be committed pending item. Useful for page
// redirects. Does nothing if there is no pending item.
@@ -152,10 +153,6 @@ struct Referrer;
- (BOOL)isSameDocumentNavigationBetweenItem:(web::NavigationItem*)firstItem
andItem:(web::NavigationItem*)secondItem;
-// Set |useDesktopUserAgentForNextPendingItem_| to YES if there is no pending
-// entry, otherwise set |useDesktopUserAgent| in the pending entry.
-- (void)useDesktopUserAgentForNextPendingItem;
-
// Returns the index of |item| in |items|.
- (NSInteger)indexOfItem:(const web::NavigationItem*)item;
« no previous file with comments | « ios/chrome/browser/tabs/tab_unittest.mm ('k') | ios/web/navigation/crw_session_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698