ios/web/public/test/fakes/test_navigation_manager.mm - Issue 2698773002: [iOS] Refactoring web CRWSessionController user agent code.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/web/public/test/fakes/test_navigation_manager.mm

Issue 2698773002: [iOS] Refactoring web CRWSessionController user agent code. (Closed)

Patch Set: Addressed feedback Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #import "ios/web/public/test/fakes/test_navigation_manager.h"	5 #import "ios/web/public/test/fakes/test_navigation_manager.h"

6	6

7 namespace web {	7 namespace web {

8	8

9 TestNavigationManager::TestNavigationManager()	9 TestNavigationManager::TestNavigationManager()

10 : pending_item_(nullptr),	10 : pending_item_(nullptr),

(...skipping 121 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
132 void TestNavigationManager::GoToIndex(int index) {	132 void TestNavigationManager::GoToIndex(int index) {

133 NOTREACHED();	133 NOTREACHED();

134 return;	134 return;

135 }	135 }

136	136

137 void TestNavigationManager::Reload(bool check_for_repost) {	137 void TestNavigationManager::Reload(bool check_for_repost) {

138 NOTREACHED();	138 NOTREACHED();

139 return;	139 return;

140 }	140 }

141	141

	142 void TestNavigationManager::OverrideDesktopUserAgentForNextPendingItem() {

	143 NOTREACHED();

	144 return;
	Eugene But (OOO till 7-30) 2017/02/16 02:20:48 Drop this Drop this liaoyuke 2017/02/16 22:04:29 Done. Show quoted text On 2017/02/16 02:20:48, Eugene But wrote: > Drop this Done.
	145 }

	146

142 } // namespace web	147 } // namespace web

OLD	NEW