[iOS] Refactoring web CRWSessionController user agent code.

ios/web/navigation/navigation_item_impl.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/web/navigation/navigation_item_impl.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <utility>
 
 #include "base/logging.h"
 #include "components/url_formatter/url_formatter.h"
+#import "ios/web/navigation/navigation_manager_impl.h"
 #include "ui/base/page_transition_types.h"
 #include "ui/gfx/text_elider.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
 #endif
 
 namespace {
 
 // Returns a new unique ID for use in NavigationItem during construction.  The
@@ skipping 13 matching lines @@
 }
 
 NavigationItemImpl::NavigationItemImpl()
     : unique_id_(GetUniqueIDInConstructor()),
       transition_type_(ui::PAGE_TRANSITION_LINK),
       is_overriding_user_agent_(false),
       is_created_from_push_state_(false),
       has_state_been_replaced_(false),
       is_created_from_hash_change_(false),
       should_skip_repost_form_confirmation_(false),
-      is_renderer_initiated_(false),
+      navigation_initiation_type_(
+          web::NavigationInitiationType::USER_INITIATED),

[kkhorimoto, 2017/02/17 20:51:35]

This should be initialized to RENDERER_INITIATED for the reasons that Eugene
mentioned before (i.e. USER_INITIATED has higher permissions, so we should
default to RENDERER_INITIATED).

[liaoyuke, 2017/02/17 22:15:40]

Per offline discussion, will do this in a separate CL.

       is_unsafe_(false),
       facade_delegate_(nullptr) {}
 
 NavigationItemImpl::~NavigationItemImpl() {
 }
 
 NavigationItemImpl::NavigationItemImpl(const NavigationItemImpl& item)
     : unique_id_(item.unique_id_),
       original_request_url_(item.original_request_url_),
       url_(item.url_),
       referrer_(item.referrer_),
       virtual_url_(item.virtual_url_),
       title_(item.title_),
       page_display_state_(item.page_display_state_),
       transition_type_(item.transition_type_),
       favicon_(item.favicon_),
       ssl_(item.ssl_),
       timestamp_(item.timestamp_),
       is_overriding_user_agent_(item.is_overriding_user_agent_),
       http_request_headers_([item.http_request_headers_ copy]),
       serialized_state_object_([item.serialized_state_object_ copy]),
       is_created_from_push_state_(item.is_created_from_push_state_),
       has_state_been_replaced_(item.has_state_been_replaced_),
       is_created_from_hash_change_(item.is_created_from_hash_change_),
       should_skip_repost_form_confirmation_(
           item.should_skip_repost_form_confirmation_),
       post_data_([item.post_data_ copy]),
-      is_renderer_initiated_(item.is_renderer_initiated_),
+      navigation_initiation_type_(item.navigation_initiation_type_),
       is_unsafe_(item.is_unsafe_),
       cached_display_title_(item.cached_display_title_),
       facade_delegate_(nullptr) {}
 
 void NavigationItemImpl::SetFacadeDelegate(
     std::unique_ptr<NavigationItemFacadeDelegate> facade_delegate) {
   facade_delegate_ = std::move(facade_delegate);
 }
 
 NavigationItemFacadeDelegate* NavigationItemImpl::GetFacadeDelegate() const {
@@ skipping 157 matching lines @@
 }
 
 void NavigationItemImpl::SetIsCreatedFromPushState(bool push_state) {
   is_created_from_push_state_ = push_state;
 }
 
 bool NavigationItemImpl::IsCreatedFromPushState() const {
   return is_created_from_push_state_;
 }
 
+void NavigationItemImpl::SetIsRendererInitiated(bool is_renderer_initiated) {
+  navigation_initiation_type_ =
+      is_renderer_initiated ? web::NavigationInitiationType::RENDERER_INITIATED
+                            : web::NavigationInitiationType::USER_INITIATED;
+}
+
+bool NavigationItemImpl::IsRendererInitiated() const {
+  return navigation_initiation_type_ ==
+         web::NavigationInitiationType::RENDERER_INITIATED;
+}
+
 void NavigationItemImpl::SetHasStateBeenReplaced(bool replace_state) {
   has_state_been_replaced_ = replace_state;
 }
 
 bool NavigationItemImpl::HasStateBeenReplaced() const {
   return has_state_been_replaced_;
 }
 
 void NavigationItemImpl::SetIsCreatedFromHashChange(bool hash_change) {
   is_created_from_hash_change_ = hash_change;
@@ skipping 26 matching lines @@
     http_request_headers_.reset();
 }
 
 void NavigationItemImpl::ResetHttpRequestHeaders() {
   http_request_headers_.reset();
 }
 
 void NavigationItemImpl::ResetForCommit() {
   // Any state that only matters when a navigation item is pending should be
   // cleared here.
-  set_is_renderer_initiated(false);
+  SetIsRendererInitiated(false);
 }
 
 }  // namespace web