third_party/WebKit/Source/modules/device_orientation/DeviceMotionController.cpp - Issue 2698723002: Add rappor logging for Device Orientation on security origins different from the main frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/device_orientation/DeviceMotionController.cpp

Issue 2698723002: Add rappor logging for Device Orientation on security origins different from the main frame (Closed)

Patch Set: add DEviceMotion Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/DeviceSingleWindowEventController.cpp ('k') | third_party/WebKit/Source/modules/device_orientation/DeviceOrientationController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/device_orientation/DeviceMotionController.cpp

diff --git a/third_party/WebKit/Source/modules/device_orientation/DeviceMotionController.cpp b/third_party/WebKit/Source/modules/device_orientation/DeviceMotionController.cpp

index 2b5780e8cf9dd428452be83a1254b15fd6ad1fc5..d54772115a691629db9e6f899cb12d3416b5e3f8 100644

--- a/third_party/WebKit/Source/modules/device_orientation/DeviceMotionController.cpp

+++ b/third_party/WebKit/Source/modules/device_orientation/DeviceMotionController.cpp

@@ -60,10 +60,16 @@ void DeviceMotionController::didAddEventListener(

}

- if (!m_hasEventListener)

+ if (!m_hasEventListener) {

Platform::current()->recordRapporURL("DeviceSensors.DeviceMotion",

WebURL(document().url()));

+ if (!isSameSecurityOriginAsMainFrame()) {

+ Platform::current()->recordRapporURL(

+ "DeviceSensors.DeviceMotionCrossOrigin", WebURL(document().url()));

+ }

DeviceSingleWindowEventController::didAddEventListener(window, eventType);

}