chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java - Issue 2698703003: [Payments] Add UI elements to secure branding for payments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

Issue 2698703003: [Payments] Add UI elements to secure branding for payments (Closed)

Patch Set: Address comments, fix animation and improve efficiency Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/res/layout/payment_request.xml ('K') | « chrome/android/java/res/layout/payment_request_header.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

index 36f29fdabc773f498b31cb6ac019d09ad7024514..14cdd1cd005c5da3c80a5e44145373520c60276f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

@@ -335,9 +335,8 @@ public class PaymentRequestImpl

mWebContents = webContents;

mMerchantName = webContents.getTitle();

- // The feature is available only in secure context, so it's OK to not show HTTPS.

- mOrigin = UrlFormatter.formatUrlForSecurityDisplay(

- mWebContents.getLastCommittedUrl(), false);

+ mOrigin =

+ UrlFormatter.formatUrlForSecurityDisplay(mWebContents.getLastCommittedUrl(), true);

mCertificateChain = CertificateChainHelper.getCertificateChain(mWebContents);

mApps = new ArrayList<>();