Forced ephemeral profile deletion on browser removal crash fix.

chrome/browser/profiles/profile_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This class keeps track of the currently-active profiles in the runtime.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_MANAGER_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_MANAGER_H_
 
 #include <stddef.h>
@@ skipping 184 matching lines @@
   void MaybeScheduleProfileForDeletion(
       const base::FilePath& profile_dir,
       const CreateCallback& callback,
       ProfileMetrics::ProfileDelete deletion_source);
 
   // Schedules the profile at the given path to be deleted on shutdown. If we're
   // deleting the last profile, a new one will be created in its place, and in
   // that case the callback will be called when profile creation is complete.
   void ScheduleProfileForDeletion(const base::FilePath& profile_dir,
                                   const CreateCallback& callback);
+
+  // Schedules the forced ephemeral profile at the given path to be deleted on

[Mike Lerman, 2017/03/01 14:24:29]

Bernhard, do Ephemeral Profiles exist on CHROME_OS? Should this call also be in
a !defined(OS_CHROMEOS) block?

[pastarmovj, 2017/03/01 16:54:25]

I can answer this one. On chromeos we offer a much better version of this
conveniently also called ephemeral profiles but which uses proper RamFS based
profiles. So this policy is not offered and used on ChromeOS at all.

[Mike Lerman, 2017/03/01 17:44:30]

Ok. Palar, can you make sure this method is also in !defined(OS_CHROMEOS)?

+  // shutdown. New profiles will not be created.
+  void ScheduleForcedEphemeralProfileForDeletion(

[Mike Lerman, 2017/03/01 14:24:29]

Why is this method public?

[palar, 2017/03/01 16:51:44]

Good catch, thx.

+      const base::FilePath& profile_dir);
 #endif
 
   // Autoloads profiles if they are running background apps.
   void AutoloadProfiles();
 
   // Checks if any ephemeral profiles are left behind (e.g. because of a browser
   // crash) and schedule them for deletion.
   void CleanUpEphemeralProfiles();
 
   // Checks if files of deleted profiles are left behind (e.g. because of a
@@ skipping 215 matching lines @@
 class ProfileManagerWithoutInit : public ProfileManager {
  public:
   explicit ProfileManagerWithoutInit(const base::FilePath& user_data_dir);
 
  protected:
   void DoFinalInitForServices(Profile*, bool) override {}
   void DoFinalInitLogging(Profile*) override {}
 };
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_MANAGER_H_