Forced ephemeral profile deletion on browser removal crash fix.

chrome/browser/profiles/profile_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This class keeps track of the currently-active profiles in the runtime.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_MANAGER_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_MANAGER_H_
 
 #include <stddef.h>
@@ skipping 184 matching lines @@
   void MaybeScheduleProfileForDeletion(
       const base::FilePath& profile_dir,
       const CreateCallback& callback,
       ProfileMetrics::ProfileDelete deletion_source);
 
   // Schedules the profile at the given path to be deleted on shutdown. If we're
   // deleting the last profile, a new one will be created in its place, and in
   // that case the callback will be called when profile creation is complete.
   void ScheduleProfileForDeletion(const base::FilePath& profile_dir,
                                   const CreateCallback& callback);
+  // Schedules the forced ephemeral profile at the given path to be deleted on

[Bernhard Bauer, 2017/02/15 18:03:30]

Nit: Empty line before comments please :)

+  // shutdown. When all browser windows are closed browser should become
+  // profileless.

[Bernhard Bauer, 2017/02/15 18:03:30]

I don't understand that sentence. When all browser windows are closed, that's
when this method is called, right?

[palar, 2017/02/16 10:39:04]

When all browser windows for exact ephemeral profile. There can be other active
profiles actualy.

[pastarmovj, 2017/02/16 10:43:26]

Since the ephemeral profile policy applies across all profiles you can safely
assume there will be no profile spared. Dunno if this info is relevant but I
agree with Bernhard that the sentence as is doesn't convey much meaning and the
name of the function plus the first sentence above to be enough documentation.

+  void ScheduleForcedEphemeralProfileForDeletion(
+      const base::FilePath& profile_dir);
 #endif
 
   // Autoloads profiles if they are running background apps.
   void AutoloadProfiles();
 
   // Checks if any ephemeral profiles are left behind (e.g. because of a browser
   // crash) and schedule them for deletion.
   void CleanUpEphemeralProfiles();
 
   // Checks if files of deleted profiles are left behind (e.g. because of a
@@ skipping 215 matching lines @@
 class ProfileManagerWithoutInit : public ProfileManager {
  public:
   explicit ProfileManagerWithoutInit(const base::FilePath& user_data_dir);
 
  protected:
   void DoFinalInitForServices(Profile*, bool) override {}
   void DoFinalInitLogging(Profile*) override {}
 };
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_MANAGER_H_