Only create PaintChunks at drawing and foreignLayer boundaries

third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/graphics/paint/PaintController.h"
 
 #include "platform/graphics/GraphicsLayer.h"
 #include "platform/graphics/paint/DrawingDisplayItem.h"
 #include "platform/instrumentation/tracing/TraceEvent.h"
 #include "third_party/skia/include/core/SkPictureAnalyzer.h"
@@ skipping 397 matching lines @@
 
   if (RuntimeEnabledFeatures::paintUnderInvalidationCheckingEnabled()) {
     DCHECK(!isCheckingUnderInvalidation());
     m_underInvalidationCheckingBegin = cachedItemIndex;
     m_underInvalidationMessagePrefix =
         "(In cached subsequence of " + cachedItem->client().debugName() + ")";
   }
 
   DisplayItem::Id endSubsequenceId(cachedItem->client(),
                                    DisplayItem::kEndSubsequence);
-  Vector<PaintChunk>::const_iterator cachedChunk;
+  Vector<PaintChunk>::const_iterator nextCachedChunk =
+      m_currentPaintArtifact.paintChunks().end();
   if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
-    cachedChunk =
-        m_currentPaintArtifact.findChunkByDisplayItemIndex(cachedItemIndex);
-    DCHECK(cachedChunk != m_currentPaintArtifact.paintChunks().end());
-    updateCurrentPaintChunkProperties(
-        cachedChunk->id ? &*cachedChunk->id : nullptr, cachedChunk->properties);
-  } else {
-    // Avoid uninitialized variable error on Windows.
-    cachedChunk = m_currentPaintArtifact.paintChunks().begin();
+    // Skip over any items that can't be paint chunk boundaries to find the
+    // first chunk following |cachedItemIndex|.
+    size_t nextChunkIndex = cachedItemIndex + 1;
+    for (; nextChunkIndex < m_currentPaintArtifact.getDisplayItemList().size();
+         nextChunkIndex++) {
+      const auto& item =
+          m_currentPaintArtifact.getDisplayItemList()[nextChunkIndex];
+      if (PaintChunker::canBeginOrEndChunk(item)) {
+        nextCachedChunk =
+            m_currentPaintArtifact.findChunkByDisplayItemIndex(nextChunkIndex);
+        DCHECK(nextCachedChunk != m_currentPaintArtifact.paintChunks().end());
+        break;
+      }
+    }
   }
 
   while (true) {
     DCHECK(cachedItem->hasValidClient());
 #if CHECK_DISPLAY_ITEM_CLIENT_ALIVENESS
     CHECK(cachedItem->client().isAlive());
 #endif
     ++m_numCachedNewItems;
     bool metEndSubsequence = cachedItem->getId() == endSubsequenceId;
     if (!RuntimeEnabledFeatures::paintUnderInvalidationCheckingEnabled()) {
       if (RuntimeEnabledFeatures::slimmingPaintV2Enabled() &&
-          cachedItemIndex == cachedChunk->endIndex) {
-        ++cachedChunk;
-        DCHECK(cachedChunk != m_currentPaintArtifact.paintChunks().end());
+          nextCachedChunk != m_currentPaintArtifact.paintChunks().end() &&
+          cachedItemIndex == nextCachedChunk->beginIndex) {
         updateCurrentPaintChunkProperties(
-            cachedChunk->id ? &*cachedChunk->id : nullptr,
-            cachedChunk->properties);
+            nextCachedChunk->id ? &*nextCachedChunk->id : nullptr,
+            nextCachedChunk->properties);
+        nextCachedChunk++;
       }
       processNewItem(moveItemFromCurrentListToNewList(cachedItemIndex));
-      if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
-        DCHECK((!m_newPaintChunks.lastChunk().id && !cachedChunk->id) ||
-               m_newPaintChunks.lastChunk().matches(*cachedChunk));
     }
 
     ++cachedItemIndex;
     if (metEndSubsequence)
       break;
 
     // We should always be able to find the EndSubsequence display item.
     DCHECK(cachedItemIndex <
            m_currentPaintArtifact.getDisplayItemList().size());
     cachedItem = &m_currentPaintArtifact.getDisplayItemList()[cachedItemIndex];
@@ skipping 401 matching lines @@
                        showPaintRecords
                            ? (DisplayItemList::JsonOptions::ShowPaintRecords |
                               DisplayItemList::JsonOptions::ShowClientDebugName)
                            : DisplayItemList::JsonOptions::ShowClientDebugName)
                    ->toPrettyJSONString()
                    .utf8()
                    .data());
 }
 
 }  // namespace blink