content/browser/web_contents/aura/overscroll_window_delegate_unittest.cc - Issue 2698673006: Add User Actions and adding more details to UMA metrics for overscroll navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/aura/overscroll_window_delegate_unittest.cc

Issue 2698673006: Add User Actions and adding more details to UMA metrics for overscroll navigation (Closed)

Patch Set: Addressing a nit Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/web_contents/aura/overscroll_window_delegate.cc ('k') | content/browser/web_contents/aura/uma_navigation_type.h » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/aura/overscroll_window_delegate_unittest.cc

diff --git a/content/browser/web_contents/aura/overscroll_window_delegate_unittest.cc b/content/browser/web_contents/aura/overscroll_window_delegate_unittest.cc

index 8a76f293d710723f4f9e1da330fe7c76ddbfab74..828bb4fa412d3688413c00602d3640acabc069c5 100644

--- a/content/browser/web_contents/aura/overscroll_window_delegate_unittest.cc

+++ b/content/browser/web_contents/aura/overscroll_window_delegate_unittest.cc

@@ -90,7 +90,8 @@ class OverscrollWindowDelegateTest : public aura::test::AuraTestBase,

}

void OnOverscrollModeChange(OverscrollMode old_mode,

- OverscrollMode new_mode) override {

+ OverscrollMode new_mode,

+ OverscrollSource source) override {

mode_changed_ = true;

current_mode_ = new_mode;

if (current_mode_ != OVERSCROLL_NONE)