content/browser/renderer_host/render_widget_host_view_aura_unittest.cc - Issue 2698673006: Add User Actions and adding more details to UMA metrics for overscroll navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

Issue 2698673006: Add User Actions and adding more details to UMA metrics for overscroll navigation (Closed)

Patch Set: Addressing feedback Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/overscroll_controller_delegate.h ('k') | content/browser/web_contents/aura/gesture_nav_simple.h » ('j') | content/browser/web_contents/aura/gesture_nav_simple.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

index 36665017959942e1c54fafe5935f6c485cf07446..decd07e7dbcc7f423fa70c23ebe9a3ae26955e73 100644

--- a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

+++ b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

@@ -156,7 +156,8 @@ class TestOverscrollDelegate : public OverscrollControllerDelegate {

}

void OnOverscrollModeChange(OverscrollMode old_mode,

- OverscrollMode new_mode) override {

+ OverscrollMode new_mode,

+ OverscrollSource source) override {

EXPECT_EQ(current_mode_, old_mode);

current_mode_ = new_mode;

delta_x_ = delta_y_ = 0.f;