third_party/WebKit/Source/platform/heap/Member.h - Issue 2698673003: Call HeapObjectHeader::checkHeader solely for its side-effect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/Member.h

Issue 2698673003: Call HeapObjectHeader::checkHeader solely for its side-effect. (Closed)

Patch Set: Use DCHECK on a bool instead of DCHECK_EQ. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/heap/Member.h

diff --git a/third_party/WebKit/Source/platform/heap/Member.h b/third_party/WebKit/Source/platform/heap/Member.h

index a4d34431b702ffc6c172fbbf426c5ecba98b8930..0baa9a97a09926290569ea408615a9c562e5d618 100644

--- a/third_party/WebKit/Source/platform/heap/Member.h

+++ b/third_party/WebKit/Source/platform/heap/Member.h

@@ -156,7 +156,7 @@ class MemberBase {

// So we currently only try to implement the check for (a), but do

// not insist that T's definition is in scope.

if (IsFullyDefined<T>::value && !IsGarbageCollectedMixin<T>::value)

- ASSERT(HeapObjectHeader::fromPayload(m_raw)->checkHeader());

+ HeapObjectHeader::fromPayload(m_raw)->checkHeader();

#endif

}