Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/bindings/core/v8/TraceWrapperMember.h

Issue 2698673003: Call HeapObjectHeader::checkHeader solely for its side-effect. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/heap/GCInfo.cpp » ('j') | third_party/WebKit/Source/platform/heap/HeapPage.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/TraceWrapperMember.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/TraceWrapperMember.h b/third_party/WebKit/Source/bindings/core/v8/TraceWrapperMember.h
index eb68310da5a219c165d454c83a5f1c66ab9e6686..090fdde39dec71067752c04da5f7e6fa22564296 100644
--- a/third_party/WebKit/Source/bindings/core/v8/TraceWrapperMember.h
+++ b/third_party/WebKit/Source/bindings/core/v8/TraceWrapperMember.h
@@ -26,7 +26,9 @@ class TraceWrapperMember : public Member<T> {
public:
TraceWrapperMember(void* parent, T* raw) : Member<T>(raw), m_parent(parent) {
#if DCHECK_IS_ON()
- DCHECK(!m_parent || HeapObjectHeader::fromPayload(m_parent)->checkHeader());
+ if (m_parent) {
+ HeapObjectHeader::fromPayload(m_parent)->checkHeader();
+ }
#endif
// We don't require a write barrier here as TraceWrapperMember is used for
// the following scenarios:
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/heap/GCInfo.cpp » ('j') | third_party/WebKit/Source/platform/heap/HeapPage.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698