Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2698663003: [css-grid] Improve intrinsic size computation with orthogonal flows (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 2132 matching lines...) Expand 10 before | Expand all | Expand 10 after
2143 if ((cb->normalChildNeedsLayout() || cb->selfNeedsLayout()) && 2143 if ((cb->normalChildNeedsLayout() || cb->selfNeedsLayout()) &&
2144 cb->isLayoutBlockFlow()) 2144 cb->isLayoutBlockFlow())
2145 toLayoutBlockFlow(cb)->removeFloatingObjects(); 2145 toLayoutBlockFlow(cb)->removeFloatingObjects();
2146 } 2146 }
2147 } 2147 }
2148 2148
2149 static bool prepareOrthogonalWritingModeRootForLayout(LayoutObject& root) { 2149 static bool prepareOrthogonalWritingModeRootForLayout(LayoutObject& root) {
2150 DCHECK(root.isBox() && toLayoutBox(root).isOrthogonalWritingModeRoot()); 2150 DCHECK(root.isBox() && toLayoutBox(root).isOrthogonalWritingModeRoot());
2151 if (!root.needsLayout() || root.isOutOfFlowPositioned() || 2151 if (!root.needsLayout() || root.isOutOfFlowPositioned() ||
2152 root.isColumnSpanAll() || 2152 root.isColumnSpanAll() ||
2153 !root.styleRef().logicalHeight().isIntrinsicOrAuto()) 2153 !root.styleRef().logicalHeight().isIntrinsicOrAuto() ||
2154 toLayoutBox(root).isGridItem())
2154 return false; 2155 return false;
2155 2156
2156 removeFloatingObjectsForSubtreeRoot(root); 2157 removeFloatingObjectsForSubtreeRoot(root);
2157 return true; 2158 return true;
2158 } 2159 }
2159 2160
2160 void FrameView::layoutOrthogonalWritingModeRoots() { 2161 void FrameView::layoutOrthogonalWritingModeRoots() {
2161 for (auto& root : m_orthogonalWritingModeRootList.ordered()) { 2162 for (auto& root : m_orthogonalWritingModeRootList.ordered()) {
2162 if (prepareOrthogonalWritingModeRootForLayout(*root)) 2163 if (prepareOrthogonalWritingModeRootForLayout(*root))
2163 layoutFromRootObject(*root); 2164 layoutFromRootObject(*root);
(...skipping 2994 matching lines...) Expand 10 before | Expand all | Expand 10 after
5158 std::unique_ptr<CompositorAnimationTimeline> timeline) { 5159 std::unique_ptr<CompositorAnimationTimeline> timeline) {
5159 m_animationTimeline = std::move(timeline); 5160 m_animationTimeline = std::move(timeline);
5160 } 5161 }
5161 5162
5162 void FrameView::setAnimationHost( 5163 void FrameView::setAnimationHost(
5163 std::unique_ptr<CompositorAnimationHost> host) { 5164 std::unique_ptr<CompositorAnimationHost> host) {
5164 m_animationHost = std::move(host); 5165 m_animationHost = std::move(host);
5165 } 5166 }
5166 5167
5167 } // namespace blink 5168 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698