Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3005)

Unified Diff: chrome/browser/ui/views/toolbar/app_menu.cc

Issue 2698613003: Don't use bold text for the "no recently closed tabs" menu item. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/toolbar/app_menu.cc
diff --git a/chrome/browser/ui/views/toolbar/app_menu.cc b/chrome/browser/ui/views/toolbar/app_menu.cc
index 6d940d5cfc20af821d3f82e05c2a4de57d575f87..c55221dff45d1be80965489fa9e874625ef6bb93 100644
--- a/chrome/browser/ui/views/toolbar/app_menu.cc
+++ b/chrome/browser/ui/views/toolbar/app_menu.cc
@@ -857,7 +857,9 @@ const gfx::FontList* AppMenu::GetLabelFontList(int command_id) const {
}
bool AppMenu::GetShouldUseNormalForegroundColor(int command_id) const {
- return IsRecentTabsCommand(command_id);
+ // Use the normal foreground color instead of the disabled color for the
+ // recent tab headers. Only the headers from that submenu have font lists.
+ return IsRecentTabsCommand(command_id) && GetLabelFontList(command_id);
Evan Stade 2017/02/16 01:30:04 this may seem a little odd but it's what the code
msw 2017/02/16 01:54:00 Can we omit the recently closed item when there ar
Evan Stade 2017/02/16 02:36:25 I think it's better to show it but have it disable
msw 2017/02/16 04:18:08 Acknowledged.
}
base::string16 AppMenu::GetTooltipText(int command_id,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698