Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 26986004: Simplify array element access in Hydrogen. (Closed)

Created:
7 years, 2 months ago by Jakob Kummerow
Modified:
7 years, 2 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Simplify array element access in Hydrogen. No change in functionality intended. R=mvstanton@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17221

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -103 lines) Patch
M src/hydrogen.h View 3 chunks +2 lines, -13 lines 0 comments Download
M src/hydrogen.cc View 12 chunks +32 lines, -90 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
This patch unifies AddExternalArrayElementAccess and AddFastElementAccess, which were doing the same thing; plus it deletes ...
7 years, 2 months ago (2013-10-15 13:39:31 UTC) #1
mvstanton
Thx for cutting back the weeds :). lgtm.
7 years, 2 months ago (2013-10-15 13:52:14 UTC) #2
Jakob Kummerow
7 years, 2 months ago (2013-10-15 15:06:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17221 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698