Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 26986003: Rerun dartium tests until we fixed the flaky crashes in issue 14074 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
===================================================================
--- tools/testing/dart/test_runner.dart (revision 28573)
+++ tools/testing/dart/test_runner.dart (working copy)
@@ -894,6 +894,11 @@
time,
compilationSkipped);
+ bool didFail(TestCase testCase) {
+ return _getOutcome() != Expectation.PASS;
+ }
+
+
bool get _browserTestFailure {
// We should not need to convert back and forward.
var output = decodeUtf8(super.stdout);
@@ -2116,14 +2121,15 @@
}
}
- if (command is BrowserTestCommand) {
- // We do not re-run tests on the new browser controller, since it should
- // not be as flaky as selenium.
- return false;
- } else if (command is SeleniumTestCommand) {
- // Selenium tests can be flaky. Try re-running.
+ // Selenium tests can be flaky. Try re-running.
+ if (command is SeleniumTestCommand) {
return true;
}
+
+ // We currently rerun dartium tests, see issue 14074
+ if (command is BrowserTestCommand && command.displayName == 'dartium') {
+ return true;
+ }
}
return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698