Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Unified Diff: gpu/ipc/service/gpu_command_buffer_stub.cc

Issue 2698573002: Support offscreen contexts which own their backing surface (Closed)
Patch Set: Rebase and retry again Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/ipc/service/gpu_command_buffer_stub.cc
diff --git a/gpu/ipc/service/gpu_command_buffer_stub.cc b/gpu/ipc/service/gpu_command_buffer_stub.cc
index 9222b3809a88642561fc1e2d9bcea3c11df99854..6977c82dd990c16e21aa1debba2eab5adae2d72d 100644
--- a/gpu/ipc/service/gpu_command_buffer_stub.cc
+++ b/gpu/ipc/service/gpu_command_buffer_stub.cc
@@ -634,7 +634,32 @@ bool GpuCommandBufferStub::Initialize(
decoder_->set_engine(executor_.get());
if (offscreen) {
- surface_ = default_surface;
+ if (init_params.attribs.depth_size > 0) {
+ surface_format.SetDepthBits(init_params.attribs.depth_size);
+ }
+ if (init_params.attribs.samples > 0) {
+ surface_format.SetSamples(init_params.attribs.samples);
+ }
+ if (init_params.attribs.stencil_size > 0) {
+ surface_format.SetStencilBits(init_params.attribs.stencil_size);
+ }
+ // Currently, we can't separately control alpha channel for surfaces,
+ // it's generally enabled by default except for RGB565 and (on desktop)
+ // smaller-than-32bit formats.
+ //
+ // TODO(klausw): use init_params.attribs.alpha_size here if possible.
+ if (!surface_format.IsCompatible(default_surface->GetFormat())) {
+ DVLOG(1) << __FUNCTION__ << ": Hit the OwnOffscreenSurface path";
+ use_virtualized_gl_context_ = false;
+ surface_ = gl::init::CreateOffscreenGLSurfaceWithFormat(gfx::Size(),
+ surface_format);
+ if (!surface_) {
+ DLOG(ERROR) << "Failed to create surface.";
+ return false;
+ }
+ } else {
+ surface_ = default_surface;
+ }
} else {
surface_ = ImageTransportSurface::CreateNativeSurface(
AsWeakPtr(), surface_handle_, surface_format);

Powered by Google App Engine
This is Rietveld 408576698