Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: components/physical_web/webui/resources/physical_web.js

Issue 2698503004: Add empty list indicator for Physical Web WebUI (Closed)
Patch Set: access hidden attr directly Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/physical_web/webui/resources/physical_web.js
diff --git a/components/physical_web/webui/resources/physical_web.js b/components/physical_web/webui/resources/physical_web.js
index 418dc1d6e90c1b5e8daffb35b8fbd841900eae08..70d856fe7db71a2222280e9cda9630a922507d4b 100644
--- a/components/physical_web/webui/resources/physical_web.js
+++ b/components/physical_web/webui/resources/physical_web.js
@@ -24,8 +24,12 @@ function physicalWebItemClicked(index) {
function returnNearbyURLs(nearbyUrlsData) {
var bodyContainer = $('body-container');
renderTemplate(nearbyUrlsData);
+ bodyContainer.hidden = false;
mmocny 2017/03/09 23:22:32 Nit: I know that if the result length is 0 that th
- bodyContainer.style.visibility = 'visible';
+ if (nearbyUrlsData['metadata'].length == 0) {
+ var emptyMessage = $('empty-list-container');
+ emptyMessage.hidden = false;
+ }
}
document.addEventListener('DOMContentLoaded', requestNearbyURLs);
« no previous file with comments | « components/physical_web/webui/resources/physical_web.html ('k') | ios/chrome/browser/ui/webui/physical_web_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698