Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: components/physical_web/webui/resources/physical_web.js

Issue 2698503004: Add empty list indicator for Physical Web WebUI (Closed)
Patch Set: add hidden attribute Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/physical_web/webui/resources/physical_web.js
diff --git a/components/physical_web/webui/resources/physical_web.js b/components/physical_web/webui/resources/physical_web.js
index 418dc1d6e90c1b5e8daffb35b8fbd841900eae08..fb2a871b78348e4c5edf66bc8a121598a922e076 100644
--- a/components/physical_web/webui/resources/physical_web.js
+++ b/components/physical_web/webui/resources/physical_web.js
@@ -24,8 +24,12 @@ function physicalWebItemClicked(index) {
function returnNearbyURLs(nearbyUrlsData) {
var bodyContainer = $('body-container');
renderTemplate(nearbyUrlsData);
+ bodyContainer.removeAttribute("hidden");
Bernhard Bauer 2017/03/09 22:10:04 You can actually directly access the .hidden attri
Ran 2017/03/09 22:28:12 Done.
- bodyContainer.style.visibility = 'visible';
+ if (nearbyUrlsData['metadata'].length == 0) {
+ var emptyMessage = $('empty-list-container');
+ emptyMessage.removeAttribute("hidden");
+ }
}
document.addEventListener('DOMContentLoaded', requestNearbyURLs);
« no previous file with comments | « components/physical_web/webui/resources/physical_web.html ('k') | ios/chrome/browser/ui/webui/physical_web_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698