Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/chrome/browser/ui/webui/physical_web_ui.cc

Issue 2698503004: Add empty list indicator for Physical Web WebUI (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/physical_web/webui/resources/physical_web.js ('K') | « components/physical_web/webui/resources/physical_web.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/webui/physical_web_ui.cc
diff --git a/ios/chrome/browser/ui/webui/physical_web_ui.cc b/ios/chrome/browser/ui/webui/physical_web_ui.cc
index 98a5cceff0eb7e8d06f509601de4da1c070380b4..79742887db63c720042c19d0655ed0fc58c1c9c6 100644
--- a/ios/chrome/browser/ui/webui/physical_web_ui.cc
+++ b/ios/chrome/browser/ui/webui/physical_web_ui.cc
@@ -28,7 +28,10 @@ web::WebUIIOSDataSource* CreatePhysicalWebUIDataSource() {
// Localized and data strings.
html_source->AddLocalizedString(physical_web_ui::kTitle,
IDS_PHYSICAL_WEB_UI_TITLE);
-
+ html_source->AddLocalizedString(physical_web_ui::kEmptyMessage,
+ IDS_PHYSICAL_WEB_UI_EMPTY_MESSAGE);
+ html_source->AddLocalizedString(physical_web_ui::kScanningMessage,
+ IDS_PHYSICAL_WEB_UI_SCANNING_MESSAGE);
mattreynolds 2017/02/23 20:18:42 nit: please fix the line wrapping so the args are
Ran 2017/02/23 20:59:46 Done.
html_source->SetJsonPath("strings.js");
html_source->AddResourcePath(physical_web_ui::kPhysicalWebJS,
IDR_PHYSICAL_WEB_UI_JS);
« components/physical_web/webui/resources/physical_web.js ('K') | « components/physical_web/webui/resources/physical_web.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698