components/physical_web/webui/resources/physical_web.html - Issue 2698503004: Add empty list indicator for Physical Web WebUI

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/physical_web/webui/resources/physical_web.html

Issue 2698503004: Add empty list indicator for Physical Web WebUI (Closed)

Patch Set: rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/physical_web/webui/physical_web_ui_constants.cc ('k') | components/physical_web/webui/resources/physical_web.js » ('j') | components/physical_web/webui/resources/physical_web.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html i18n-values="dir:textdirection;lang:language">	2 <html i18n-values="dir:textdirection;lang:language">

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <title i18n-content="title"></title>	5 <title i18n-content="title"></title>

6 <if expr="is_android or is_ios">	6 <if expr="is_android or is_ios">

7 <meta name="viewport" content="width=device-width, user-scalable=no">	7 <meta name="viewport" content="width=device-width, user-scalable=no">

8 </if>	8 </if>

9 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css">	9 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css">

10 <link rel="stylesheet" href="chrome://physical-web/physical_web.css">	10 <link rel="stylesheet" href="chrome://physical-web/physical_web.css">

(...skipping 20 matching lines...) Expand all Loading...
31 </div>	31 </div>

32 <div class="physicalWebText">	32 <div class="physicalWebText">

33 <div class="title" jscontent="pageInfoTitle"></div>	33 <div class="title" jscontent="pageInfoTitle"></div>

34 <div class="resolvedUrl" jscontent="resolvedUrl"></div>	34 <div class="resolvedUrl" jscontent="resolvedUrl"></div>

35 <div class="description" jscontent="pageInfoDescription"></div>	35 <div class="description" jscontent="pageInfoDescription"></div>

36 </div>	36 </div>

37 </a>	37 </a>

38	38

39 </div>	39 </div>

40	40

	41 <div id="empty-container" i18n-content="emptyMessage" style="visibility:hidden">
	cco3 2017/02/23 20:07:31 Is there a reason we should do visibility:hidden i Is there a reason we should do visibility:hidden instead of display:none? Same with below for display:block Also, I think the css should be in physical_web.css Ran 2017/02/23 20:59:45 Moved css to physical_web.css. For visibility over Show quoted text On 2017/02/23 20:07:31, cco3 wrote: > Is there a reason we should do visibility:hidden instead of display:none? Same > with below for display:block > > Also, I think the css should be in physical_web.css Moved css to physical_web.css. For visibility over display, I was referring the "body-container" and try to make it consistent.
	42 </div>

	43

	44 <div id="scan-container" i18n-content="scanningMessage" style="visibility:visibl e">

	45 </div>

	46

41 <script src="chrome://resources/js/i18n_template.js"></script>	47 <script src="chrome://resources/js/i18n_template.js"></script>

42 <script src="chrome://resources/js/jstemplate_compiled.js"></script>	48 <script src="chrome://resources/js/jstemplate_compiled.js"></script>

43 </body>	49 </body>

44 </html>	50 </html>

OLD	NEW