Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: chrome/browser/chromeos/net/network_portal_notification_controller.cc

Issue 2698473007: Convert path usage in NetworkListViewBase subclasses to use guids. (Closed)
Patch Set: Tweak NetworkPortalNotificationControllerTest to create GUIDs for new NetworkStates. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/net/network_portal_notification_controller.cc
diff --git a/chrome/browser/chromeos/net/network_portal_notification_controller.cc b/chrome/browser/chromeos/net/network_portal_notification_controller.cc
index 868f40c6295ff9d36f3883d165ebbedfd6f8c9c2..a25aaa26b639b893f3ff05c79d630fdba6bb56c0 100644
--- a/chrome/browser/chromeos/net/network_portal_notification_controller.cc
+++ b/chrome/browser/chromeos/net/network_portal_notification_controller.cc
@@ -275,7 +275,7 @@ void NetworkPortalNotificationController::OnPortalDetectionCompleted(
if (!network ||
state.status != NetworkPortalDetector::CAPTIVE_PORTAL_STATUS_PORTAL) {
- last_network_path_.clear();
+ last_network_guid_.clear();
// In browser tests we initiate fake network portal detection, but network
// state usually stays connected. This way, after dialog is shown, it is
@@ -296,13 +296,13 @@ void NetworkPortalNotificationController::OnPortalDetectionCompleted(
// Don't do anything if notification for |network| already was
// displayed.
- if (network->path() == last_network_path_)
+ if (network->guid() == last_network_guid_)
return;
- last_network_path_ = network->path();
+ last_network_guid_ = network->guid();
if (ash::WmShell::HasInstance()) {
ash::WmShell::Get()->system_tray_notifier()->NotifyOnCaptivePortalDetected(
- network->path());
+ network->guid());
}
message_center::MessageCenter::Get()->AddNotification(

Powered by Google App Engine
This is Rietveld 408576698