ash/common/system/chromeos/network/tray_network.cc - Issue 2698473007: Convert path usage in NetworkListViewBase subclasses to use guids.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/system/chromeos/network/tray_network.cc

Issue 2698473007: Convert path usage in NetworkListViewBase subclasses to use guids. (Closed)

Patch Set: Tweak NetworkPortalNotificationControllerTest to create GUIDs for new NetworkStates. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/common/system/chromeos/network/tray_network.cc

diff --git a/ash/common/system/chromeos/network/tray_network.cc b/ash/common/system/chromeos/network/tray_network.cc

index 5284453a7239e1d442a5398ea7f569c891a37d96..44c38399c1ca88e251aad7cacd580603ee855172 100644

--- a/ash/common/system/chromeos/network/tray_network.cc

+++ b/ash/common/system/chromeos/network/tray_network.cc

@@ -323,8 +323,7 @@ void TrayNetwork::RequestToggleWifi() {

chromeos::network_handler::ErrorCallback());

}

-void TrayNetwork::OnCaptivePortalDetected(

- const std::string& /* service_path */) {

+void TrayNetwork::OnCaptivePortalDetected(const std::string& /* guid */) {

NetworkStateChanged();

}