Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: chrome/browser/ui/ash/networking_config_delegate_chromeos.cc

Issue 2698473007: Convert path usage in NetworkListViewBase subclasses to use guids. (Closed)
Patch Set: Tweak NetworkPortalNotificationControllerTest to create GUIDs for new NetworkStates. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/ash/networking_config_delegate_chromeos.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/ash/networking_config_delegate_chromeos.h" 5 #include "chrome/browser/ui/ash/networking_config_delegate_chromeos.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <string> 8 #include <string>
9 9
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
11 #include "chrome/browser/profiles/profile_manager.h" 11 #include "chrome/browser/profiles/profile_manager.h"
12 #include "chromeos/network/network_state.h" 12 #include "chromeos/network/network_state.h"
13 #include "chromeos/network/network_state_handler.h" 13 #include "chromeos/network/network_state_handler.h"
14 #include "extensions/browser/api/networking_config/networking_config_service.h" 14 #include "extensions/browser/api/networking_config/networking_config_service.h"
15 #include "extensions/browser/api/networking_config/networking_config_service_fac tory.h" 15 #include "extensions/browser/api/networking_config/networking_config_service_fac tory.h"
16 #include "extensions/browser/extension_registry.h" 16 #include "extensions/browser/extension_registry.h"
17 #include "extensions/common/extension.h" 17 #include "extensions/common/extension.h"
18 18
19 namespace chromeos { 19 namespace chromeos {
20 20
21 NetworkingConfigDelegateChromeos::NetworkingConfigDelegateChromeos() { 21 NetworkingConfigDelegateChromeos::NetworkingConfigDelegateChromeos() {
22 } 22 }
23 23
24 NetworkingConfigDelegateChromeos::~NetworkingConfigDelegateChromeos() { 24 NetworkingConfigDelegateChromeos::~NetworkingConfigDelegateChromeos() {
25 } 25 }
26 26
27 std::unique_ptr<const ash::NetworkingConfigDelegate::ExtensionInfo> 27 std::unique_ptr<const ash::NetworkingConfigDelegate::ExtensionInfo>
28 NetworkingConfigDelegateChromeos::LookUpExtensionForNetwork( 28 NetworkingConfigDelegateChromeos::LookUpExtensionForNetwork(
29 const std::string& service_path) { 29 const std::string& guid) {
30 chromeos::NetworkStateHandler* handler = 30 chromeos::NetworkStateHandler* handler =
31 chromeos::NetworkHandler::Get()->network_state_handler(); 31 chromeos::NetworkHandler::Get()->network_state_handler();
32 const chromeos::NetworkState* network_state = 32 const chromeos::NetworkState* network_state =
33 handler->GetNetworkState(service_path); 33 handler->GetNetworkStateFromGuid(guid);
34 if (!network_state) 34 if (!network_state)
35 return nullptr; 35 return nullptr;
36 std::string hex_ssid = network_state->GetHexSsid(); 36 std::string hex_ssid = network_state->GetHexSsid();
37 Profile* profile = ProfileManager::GetActiveUserProfile(); 37 Profile* profile = ProfileManager::GetActiveUserProfile();
38 extensions::NetworkingConfigService* networking_config_service = 38 extensions::NetworkingConfigService* networking_config_service =
39 extensions::NetworkingConfigServiceFactory::GetForBrowserContext(profile); 39 extensions::NetworkingConfigServiceFactory::GetForBrowserContext(profile);
40 const std::string extension_id = 40 const std::string extension_id =
41 networking_config_service->LookupExtensionIdForHexSsid(hex_ssid); 41 networking_config_service->LookupExtensionIdForHexSsid(hex_ssid);
42 if (extension_id.empty()) 42 if (extension_id.empty())
43 return nullptr; 43 return nullptr;
(...skipping 14 matching lines...) Expand all
58 extensions::ExtensionRegistry::Get(context); 58 extensions::ExtensionRegistry::Get(context);
59 DCHECK(extension_registry); 59 DCHECK(extension_registry);
60 const extensions::Extension* extension = extension_registry->GetExtensionById( 60 const extensions::Extension* extension = extension_registry->GetExtensionById(
61 extension_id, extensions::ExtensionRegistry::ENABLED); 61 extension_id, extensions::ExtensionRegistry::ENABLED);
62 if (extension == nullptr) 62 if (extension == nullptr)
63 return std::string(); 63 return std::string();
64 return extension->name(); 64 return extension->name();
65 } 65 }
66 66
67 } // namespace chromeos 67 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/ui/ash/networking_config_delegate_chromeos.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698