Convert path usage in NetworkListViewBase subclasses to use guids.

ash/common/system/chromeos/network/network_state_list_detailed_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/chromeos/network/network_state_list_detailed_view.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "ash/common/ash_constants.h"
@@ skipping 384 matching lines @@
     owner()->system_tray()->CloseSystemBubble();
 }
 
 void NetworkStateListDetailedView::HandleViewClicked(views::View* view) {
   // If the info bubble was visible, close it when some other item is clicked.
   ResetInfoBubble();
 
   if (login_ == LoginStatus::LOCKED)
     return;
 
-  std::string service_path;
-  if (!network_list_view_->IsNetworkEntry(view, &service_path))
+  std::string guid;
+  if (!network_list_view_->IsNetworkEntry(view, &guid))
     return;
 
   const NetworkState* network =
-      NetworkHandler::Get()->network_state_handler()->GetNetworkState(
-          service_path);
+      NetworkHandler::Get()->network_state_handler()->GetNetworkStateFromGuid(
+          guid);
   if (!network || network->IsConnectedState() || network->IsConnectingState()) {
     WmShell::Get()->RecordUserMetricsAction(
         list_type_ == LIST_TYPE_VPN
             ? UMA_STATUS_AREA_SHOW_NETWORK_CONNECTION_DETAILS
             : UMA_STATUS_AREA_SHOW_VPN_CONNECTION_DETAILS);
     WmShell::Get()->system_tray_controller()->ShowNetworkSettings(
         network ? network->guid() : std::string());
   } else {
     WmShell::Get()->RecordUserMetricsAction(
         list_type_ == LIST_TYPE_VPN
@@ skipping 214 matching lines @@
   return controlled_by_extension_icon_.ToImageSkia();
 }
 
 views::View* NetworkStateListDetailedView::CreateControlledByExtensionView(
     const NetworkInfo& info) {
   NetworkingConfigDelegate* networking_config_delegate =
       WmShell::Get()->system_tray_delegate()->GetNetworkingConfigDelegate();
   if (!networking_config_delegate)
     return nullptr;
   std::unique_ptr<const NetworkingConfigDelegate::ExtensionInfo>
-      extension_info = networking_config_delegate->LookUpExtensionForNetwork(
-          info.service_path);
+      extension_info =
+          networking_config_delegate->LookUpExtensionForNetwork(info.guid);

[stevenjb, 2017/02/16 22:40:31]

This delegate function needs to be modified to accept guid. I think this is the
only place it is called from though.

[Ryan Hansberry, 2017/02/16 23:14:18]

Thankfully this was the only place that calls this. :)

   if (!extension_info)
     return nullptr;
 
   // Get the tooltip text.
   base::string16 tooltip_text = l10n_util::GetStringFUTF16(
       IDS_ASH_STATUS_TRAY_EXTENSION_CONTROLLED_WIFI,
       base::UTF8ToUTF16(extension_info->extension_name));
 
   views::ImageView* controlled_icon =
       new FixedSizedImageView(kTrayPopupDetailsIconWidth, 0);
@@ skipping 85 matching lines @@
       UMA_STATUS_AREA_NETWORK_JOIN_OTHER_CLICKED);
   WmShell::Get()->system_tray_controller()->ShowNetworkCreate(shill::kTypeWifi);
 }
 
 void NetworkStateListDetailedView::RelayoutScrollList() {
   scroller()->Layout();
 }
 
 }  // namespace tray
 }  // namespace ash