ios/chrome/browser/ui/history/BUILD.gn - Issue 2698473004: Split FaviconService and FaviconServiceImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/history/BUILD.gn

Issue 2698473004: Split FaviconService and FaviconServiceImpl. (Closed)

Patch Set: Revert changes in ios/.../history_collection_view_controller_unittest.mm Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/history/BUILD.gn

diff --git a/ios/chrome/browser/ui/history/BUILD.gn b/ios/chrome/browser/ui/history/BUILD.gn

index 8f8dbd0cf1f03f6d6d5c32910918d01c3ca0f97b..892643980a0c7c37f49562113c4ca793cd9a5d7a 100644

--- a/ios/chrome/browser/ui/history/BUILD.gn

+++ b/ios/chrome/browser/ui/history/BUILD.gn

@@ -107,6 +107,7 @@ source_set("unit_tests") {

"//base",

"//base/test:test_support",

"//components/favicon/core",

+ "//components/favicon/core/test:test_support",

"//components/favicon_base",

"//components/history/core/browser",

"//components/keyed_service/core",

@@ -126,6 +127,7 @@ source_set("unit_tests") {

"//ios/web",

"//ios/web:test_support",

"//skia",

+ "//testing/gmock",

"//testing/gtest",

"//third_party/ocmock",

"//ui/base",