components/history/core/browser/history_service.h - Issue 2698473004: Split FaviconService and FaviconServiceImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/history_service.h

Issue 2698473004: Split FaviconService and FaviconServiceImpl. (Closed)

Patch Set: Revert changes in ios/.../history_collection_view_controller_unittest.mm Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/history/core/browser/history_service.h

diff --git a/components/history/core/browser/history_service.h b/components/history/core/browser/history_service.h

index 8e34834e22ae03fd8a2705560330ddd434c13f86..dd6b19aa490f1898e9413cc7fa355269966a4ef5 100644

--- a/components/history/core/browser/history_service.h

+++ b/components/history/core/browser/history_service.h

@@ -53,7 +53,7 @@ class Thread;

}

namespace favicon {

-class FaviconService;

+class FaviconServiceImpl;

}

namespace history {

@@ -544,7 +544,7 @@ class HistoryService : public syncer::SyncableService, public KeyedService {

class BackendDelegate;

friend class base::RefCountedThreadSafe<HistoryService>;

friend class BackendDelegate;

- friend class favicon::FaviconService;

+ friend class favicon::FaviconServiceImpl;

friend class HistoryBackend;

friend class HistoryQueryTest;

friend class ::HistoryQuickProviderTest;